Skip to content

OCPEDGE-1485: Add initial version of etcd kill and recovery test #30320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

OCPEDGE-1485: Add initial version of etcd kill and recovery test #30320

wants to merge 4 commits into from

Conversation

@fonta-rh
Copy link

@fonta-rh fonta-rh commented Sep 30, 2025 •
edited
Loading

Add etcd process crash recovery test for TNF clusters

Add test to validate Two Node with Fencing (TNF) cluster recovery after etcd process crashes.

The test kills the etcd process/container on one node and validates that Pacemaker automatically detects the failure and restarts etcd, with the cluster returning to a healthy state (both nodes as started voting members).

Test approach:

  • Kills etcd using multiple methods (podman kill, pkill, systemctl stop)
  • Retries validation every 2 minutes for up to 6 minutes total
  • Uses GinkgoRecover() to properly handle validation panics within Eventually retry logic
  • Validates both etcd member state and operator health

Related: OCPBUGS-59238 (etcd process crash recovery issue in TNF clusters)

NOTE: This test doesn't work on an un-patched, un-reconfigured TNF cluster at the moment. It's set to be skipped until that point

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fonta-rh
Once this PR has been reviewed and has the lgtm label, please assign jaypoulz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fonta-rh fonta-rh changed the title Add initial version of etcd kill and recovery test OCPEDGE-1485: Add initial version of etcd kill and recovery test Oct 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Add test for TNF etcd recovery from fatal failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fonta-rh fonta-rh marked this pull request as ready for review October 23, 2025 10:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025 •
edited by openshift-ci bot
Loading

@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue.

In response to this:

Add test for TNF etcd recovery from fatal etcd pod failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-trt
Copy link

openshift-trt bot commented Oct 23, 2025

Job Failure Risk Analysis for sha: 51df2c4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (18) are below the historical average (1830): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (19) are below the historical average (1831): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@fonta-rh fonta-rh force-pushed the OCPEDGE-1485-TNF-etcd-failure-recovery-test branch from 51df2c4 to cf634ab Compare October 24, 2025 09:06
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2025 •
edited by openshift-ci bot
Loading

@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue.

In response to this:

Add etcd process crash recovery test for TNF clusters

Add test to validate Two Node with Fencing (TNF) cluster recovery after etcd process crashes.

The test kills the etcd process/container on one node and validates that Pacemaker automatically detects the failure and restarts etcd, with the cluster returning to a healthy state (both nodes as started voting members).

Test approach:

  • Kills etcd using multiple methods (podman kill, pkill, systemctl stop)
  • Retries validation every 2 minutes for up to 6 minutes total
  • Uses GinkgoRecover() to properly handle validation panics within Eventually retry logic
  • Validates both etcd member state and operator health

Related: OCPBUGS-59238 (etcd process crash recovery issue in TNF clusters)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2025 •
edited by openshift-ci bot
Loading

@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue.

In response to this:

Add etcd process crash recovery test for TNF clusters

Add test to validate Two Node with Fencing (TNF) cluster recovery after etcd process crashes.

The test kills the etcd process/container on one node and validates that Pacemaker automatically detects the failure and restarts etcd, with the cluster returning to a healthy state (both nodes as started voting members).

Test approach:

  • Kills etcd using multiple methods (podman kill, pkill, systemctl stop)
  • Retries validation every 2 minutes for up to 6 minutes total
  • Uses GinkgoRecover() to properly handle validation panics within Eventually retry logic
  • Validates both etcd member state and operator health

Related: OCPBUGS-59238 (etcd process crash recovery issue in TNF clusters)

NOTE: This test doesn't work on an un-patched, un-reconfigured TNF cluster at the moment. It's set to be skipped until that point

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

@fonta-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 51df2c4 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial-2of2 993cf45 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-vsphere-ovn 993cf45 link true /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eggfoobar eggfoobar Awaiting requested review from eggfoobar

@jeff-roche jeff-roche Awaiting requested review from jeff-roche

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fonta-rh @openshift-ci-robot